[ 
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428702#comment-17428702
 ] 

Jan Høydahl commented on LUCENE-9997:
-------------------------------------

A nice property of the Python smoketester is that it will also catch bugs and 
regressions in the gradle build itself. What if a gradle check is inadvertently 
removed? The smoketester gives an "outside perspective" on the result of the 
whole build, packaging, signing, publishing etc, and validates that the 
actually published bits are in compliance and work.

I absolutely believe we can and should add more early checks, but some of the 
most important checks benefit from being duplicated.

One example is javadoc broken links checks. I think the smoketester in 8.x 
checks the javadocs links, but not in 9.x, and I believe the reason is that the 
gradle build already does that if I'm not mistaken?

> Revisit smoketester for 9.0 build
> ---------------------------------
>
>                 Key: LUCENE-9997
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9997
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Robert Muir
>            Priority: Major
>         Attachments: image-2021-10-12-12-47-11-480.png, 
> image-2021-10-12-12-48-15-373.png
>
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Currently we have a (great) {{dev-tools/scripts/smokeTester.py}} that will 
> perform automated tests against a release.
> This was developed with the ant build process in mind.
> This issue is just about considering the automated checks we do here, maybe 
> some of them can be done efficiently in the gradle build in earlier places: 
> this would be a large improvement!
> Obviously some of them (e.g. GPG release key verifications) are really 
> specific to the artifacts in question. These are most important to release 
> verification, as that is actually the only place we can check it.
> Any other checks (and I do tend to think, this checker should try to be 
> thorough, invoking gradle etc), should be stuff we regularly test in 
> PRs/nightly/builds.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to