[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427342#comment-17427342
]
Robert Muir commented on LUCENE-9997:
-------------------------------------
Some history: originally we had no smoketester.
Every release had a lot of ppl hand-checking various random stuff, to ensure
the artifacts were correct.
It made it very difficult to release. None of these problems (e.g. build system
bugs) would surface until release time, no regression testing.
We added the smoketester, if an issue came up in the release VOTE, we'd fix the
tester to detect it too. At least it gave the RM a chance to "locally test
stuff out" more efficiently and prevent the same issues from popping up every
VOTE.
We added a "ant nightly-smoke" target, which issued a release every night, and
then ran the smoketester on it, and made it a nightly job. The idea is to catch
problem even sooner. The problem with this, is that nobody paid attention to
the builds@ mailing list, because solr tests fail all the time. This problem
remains to this day, even though its a separate PMC.
The problem impacts more than just releases, but even simple commits. I cannot
with confidence simply merge a good-looking PR on my mobile phone, because our
PRs don't simply run the tests for me. Instead I need to wait to sit at my
computer, add the contributor as a remote, check it all out manually, before I
can press the merge button. Honestly this 2nd step probably fails to happen
sometimes.
I just think in general, we should be "testing" stuff at as early as possible a
phase, to make our own lives easier. And this includes the build system.
That being said, I don't think we should try to issue a 9.0 release without any
smoketester. We should have SOMETHING, so +1 to fix the existing smoketester to
play well with the 9.0 build if that is the easiest step.
> Revisit smoketester for 9.0 build
> ---------------------------------
>
> Key: LUCENE-9997
> URL: https://issues.apache.org/jira/browse/LUCENE-9997
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Robert Muir
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently we have a (great) {{dev-tools/scripts/smokeTester.py}} that will
> perform automated tests against a release.
> This was developed with the ant build process in mind.
> This issue is just about considering the automated checks we do here, maybe
> some of them can be done efficiently in the gradle build in earlier places:
> this would be a large improvement!
> Obviously some of them (e.g. GPG release key verifications) are really
> specific to the artifacts in question. These are most important to release
> verification, as that is actually the only place we can check it.
> Any other checks (and I do tend to think, this checker should try to be
> thorough, invoking gradle etc), should be stuff we regularly test in
> PRs/nightly/builds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
