rmuir commented on pull request #360: URL: https://github.com/apache/lucene/pull/360#issuecomment-939291709
I removed the custom pkg-private ctor for testing. Added constants for min/max values. Added some javadocs for the ctors and some tests for the illegal values. `expectThrows` was mysteriously missing, it was because the test didnt extend LuceneTestCase, I addressed that too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
