[
https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424636#comment-17424636
]
Robert Muir commented on LUCENE-10149:
--------------------------------------
I ran tests again with {{gradle coverage}} and it looks all tested:
!Screen_Shot_2021-10-05_at_14.05.42.png!
But I looked at the unit test and it doesn't directly test these methods. Let's
improve this...
It does have a separate test for the whole Directory extending
BaseDirectoryTestCase so that's another avenue.
> ByteBuffersDataInput should override readShort/Int/Long
> -------------------------------------------------------
>
> Key: LUCENE-10149
> URL: https://issues.apache.org/jira/browse/LUCENE-10149
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Priority: Major
> Attachments: LUCENE-10149.patch,
> Screen_Shot_2021-10-05_at_14.05.42.png
>
>
> ByteBuffersDataInput currently only optimizes the absolute {{readShort(long
> pos)}}, {{readInt(long pos)}}, {{readLong(long pos)}}.
> This is good because these are e.g. used by docvalues.
> On the other hand it should also optimize the relative {{readShort()}},
> {{readInt()}}, and {{readLong()}} in the same way. In some cases these are
> performance sensitive too. For example, the postings list compression uses
> {{readLong()}}.
> Looking at the code, this seems to be a simple oversight.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
