[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424453#comment-17424453 ]
Robert Muir commented on LUCENE-10149: -------------------------------------- These are fashioned to look consistent with the positional methods (e.g. {{readShort(long pos)}}) which are already implemented. > ByteBuffersDataInput should override readShort/Int/Long > ------------------------------------------------------- > > Key: LUCENE-10149 > URL: https://issues.apache.org/jira/browse/LUCENE-10149 > Project: Lucene - Core > Issue Type: Task > Reporter: Robert Muir > Priority: Major > Attachments: LUCENE-10149.patch > > > ByteBuffersDataInput currently only optimizes the absolute {{readShort(long > pos)}}, {{readInt(long pos)}}, {{readLong(long pos)}}. > This is good because these are e.g. used by docvalues. > On the other hand it should also optimize the relative {{readShort()}}, > {{readInt()}}, and {{readLong()}} in the same way. In some cases these are > performance sensitive too. For example, the postings list compression uses > {{readLong()}}. > Looking at the code, this seems to be a simple oversight. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org