[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424332#comment-17424332
]
Uwe Schindler commented on LUCENE-10143:
----------------------------------------
Hi,
I opened a new pull request to fix the original issue (rate limiter):
https://github.com/apache/lucene/pull/352
I used the eclipse funtionality to generate a full delegator, but I wasn't aber
to delegate writeVInt & co, as those are declared final in DataOutput. I think
back at that time we did not want for subclasses to make it more complex. For
DataInputs we are more about performance than for data output, so there they
should be always delegated.
Unfortunately the DataOutput class is not very consistent: writeBytes(byte[],
int) should be final, too because overriding it makes no sense (its just a
delegator). We should fix this in another issue.
bq. I also think the DataInput vs IndexInput causes more trouble than its worth
with this duplication. It definitely makes it more difficult to consolidate and
reuse some of this stuff.
I think we should make this a new issue.
> RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong
> --------------------------------------------------------------------
>
> Key: LUCENE-10143
> URL: https://issues.apache.org/jira/browse/LUCENE-10143
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: screenshot-1.png
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Otherwise merges are not taking advantage of LUCENE-10125.
> cc [~uschindler]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
