[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424075#comment-17424075
]
Robert Muir commented on LUCENE-10143:
--------------------------------------
In general, I'm gonna say the "incomplete delegator" case isn't worth trying to
address here. Only the rate limiter is a delegator!
The general problem is just many classes having inefficient readInt/Long/Short.
But there are also just as many classes where the slow implementation is just
fine (maybe because only vints are used, or because the class isn't performance
sensitive).
So I agree, let's not make the methods abstract as it makes a lot of noise. But
let's also not add crazy build logic or lomboks or anything when that only
would detect the issue for a single class and not even solve the general issue.
We should look into the other impacted classes and see if they can be faster.
> RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong
> --------------------------------------------------------------------
>
> Key: LUCENE-10143
> URL: https://issues.apache.org/jira/browse/LUCENE-10143
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: screenshot-1.png
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Otherwise merges are not taking advantage of LUCENE-10125.
> cc [~uschindler]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
