gsmiller commented on pull request #233: URL: https://github.com/apache/lucene/pull/233#issuecomment-900434388
@jpountz I think that's a fair view of this work. Apologies for overlooking the past related discussions as well; looks like it does overlap a fair amount with these. From my side, I've seen a couple different use-cases in how we use Lucene where we essentially do an inner join across multiple `DoubleValues`/`LongValues` and only do some processing when a doc contains a value in all of them. So this functionality would be a bit more helpful in those cases, but I agree that it doesn't save a substantial amount of code (but would be nice to write it once and reuse it, even though it's not that significant). Coming back to Lucene more generally though, there aren't as many applications for this as I anticipated, and the applications I've found are "joining" with a single value only, so I think it would be hard to make a case for adding this. I'll park this change and close the PR for now (and pull this code into a local utility for our specific use-cases). Thanks as always for the feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
