gsmiller commented on a change in pull request #233:
URL: https://github.com/apache/lucene/pull/233#discussion_r686017224
##########
File path: lucene/core/src/java/org/apache/lucene/search/ConjunctionUtils.java
##########
@@ -97,4 +97,11 @@ public static void addIterator(
List<TwoPhaseIterator> twoPhaseIterators) {
ConjunctionDISI.addIterator(disi, allIterators, twoPhaseIterators);
}
+
+ /**
+ * Create a conjunction for a given lead {@link DocIdSetIterator} and an
array of {@link Values}.
+ */
+ public static DocIdSetIterator createValuesConjunction(DocIdSetIterator
lead, Values[] values) {
Review comment:
Thanks for the suggestion! Definitely more flexible and modern. I need
to spend a little more time looking at the rest of the `ConjunctionUtils`
use-cases to determine if it makes more sense to use a `List` here for
consistency with the rest of the helper methods. Hoping to make some time to
dig a little deeper later in this week. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
