gf53520 edited a comment on pull request #231: URL: https://github.com/apache/lucene/pull/231#issuecomment-899177506
> @gf53520 Sorry for the late response. I was offline last week. > > After taking another look, I think we should not introduce another `size` method in MergePolicy, but wrap MergeContext to cache `numDeletesToMerge` in SoftDeletesRetentionMergePolicy instead. I know this is not ideal, but it's less confusing than the current approach. @dnhatn ok, I think make that cache for SoftDeletesRetentionMergePolicy is more elegrant, considering that size method is only useful in soft-deletes case. I close this mr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
