[ https://issues.apache.org/jira/browse/LUCENE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391275#comment-17391275 ]
weizijun commented on LUCENE-10014: ----------------------------------- hi, [~jpountz] , I add this Improvement both in Lucene90DocValuesFormat and Lucene80DocValuesFormat,and add more test case in `doTestSortedNumericBlocksOfVariousBitsPerValue`. as in `blocksOfVariousBPV`, if mul is bigger then 1, gcd will work. I add a case to test, the data write to docvalues and read from docvalues are the same. > docvalue writeBlock gcd encode improve > -------------------------------------- > > Key: LUCENE-10014 > URL: https://issues.apache.org/jira/browse/LUCENE-10014 > Project: Lucene - Core > Issue Type: Improvement > Components: core/codecs > Reporter: weizijun > Priority: Major > Attachments: LUCENE-10014.patch > > > Lucene90DocValuesConsumer.writeBlock calculate bitsPerValue as: > {code:java} > final int bitsPerValue = DirectWriter.unsignedBitsRequired(max - min); > {code} > it can use gcd in this place as: > {code:java} > (max - min) / gcd > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org