[
https://issues.apache.org/jira/browse/LUCENE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372963#comment-17372963
]
Adrien Grand commented on LUCENE-10014:
---------------------------------------
Good catch, this looks right. Could you update Lucene80DocValuesFormat too,
which seems affected by the same issue?
I also worry we don't have testing for this special case of mixing GCD
compression with blocks. Could you add a new test similar to
{{TestLucene90DocValuesFormat#testSortedNumericBlocksOfVariousBitsPerValue}}?
> docvalue writeBlock gcd encode improve
> --------------------------------------
>
> Key: LUCENE-10014
> URL: https://issues.apache.org/jira/browse/LUCENE-10014
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Reporter: weizijun
> Priority: Major
> Attachments: LUCENE-10014.patch
>
>
> Lucene90DocValuesConsumer.writeBlock calculate bitsPerValue as:
> {code:java}
> final int bitsPerValue = DirectWriter.unsignedBitsRequired(max - min);
> {code}
> it can use gcd in this place as:
> {code:java}
> (max - min) / gcd
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
