[ 
https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385159#comment-17385159
 ] 

Gautam Worah commented on LUCENE-9450:
--------------------------------------

[~jpountz] I think your points make sense. Version based checks are definitely 
cleaner and can act as self documentation on what changed. 

I had not thought about the migration process when I was thinking about the 
index using a different name approach.

In the meantime, I had already submitted a 
[PR|https://github.com/apache/lucene/pull/220] with approach 1 yesterday. I'll 
revise it with version based checks

> Taxonomy index should use DocValues not StoredFields
> ----------------------------------------------------
>
>                 Key: LUCENE-9450
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9450
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>    Affects Versions: 8.5.2
>            Reporter: Gautam Worah
>            Priority: Minor
>              Labels: performance
>             Fix For: main (9.0)
>
>         Attachments: LUCENE-9450-localrun.py-v1, wip_taxonomy_patch
>
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> The taxonomy index that maps binning labels to ordinals was created before 
> Lucene added BinaryDocValues.
> I've attached a WIP patch (does not pass tests currently)
> Issue suggested by [~mikemccand]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to