[ 
https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373654#comment-17373654
 ] 

ASF subversion and git services commented on LUCENE-9944:
---------------------------------------------------------

Commit 22c1c78bb395c77de19d6d9e9677b6efa872c11f in lucene's branch 
refs/heads/branch_8x from Greg Miller
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=22c1c78 ]

LUCENE-9962, LUCENE-9944, LUCENE-9988: DrillSideways improvement backports 
(#2506)

* LUCENE-9962: Allow DrillSideways sub-classes to provide their own "drill 
down" facet counting implementation (or null)
* LUCENE-9944: Allow DrillSideways users to pass a CollectorManager without 
requiring an ExecutorService (and concurrent DrillSideways approach)
* LUCENE-9988: Fix DrillSideways bug discovered in randomized testing

> Implement alternative drill sideways faceting with provided CollectorManager
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-9944
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9944
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>    Affects Versions: main (9.0)
>            Reporter: Greg Miller
>            Priority: Minor
>             Fix For: main (9.0), 8.10
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Today, if a user of {{DrillSideways}} wants to provide their own 
> {{CollectorManager}} when invoking {{search}}, they get this alternate, 
> "concurrent" implementation that creates N copies of the provided 
> {{DrillDownQuery}} (where N is the number of drill-down dimensions) and runs 
> them all concurrently. This is a very different implementation than the one a 
> user would get if providing a {{Collector}} instead. Additionally, an 
> {{ExecutorService}} must be provided when constructing a {{DrillSideways}} 
> instance if the user wants to bring their own {{CollectorManager}} 
> (otherwise, they'll get an unfriendly NPE when calling {{search}}).
> I propose adding an implementation to {{DrillSideways}} that will run the 
> "non-concurrent" algorithm in the case that a user wants to provide their own 
> {{CollectorManager}} but doesn't want to provide an {{ExecutorService}} (and 
> doesn't want the concurrent algorithm).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to