glawson0 commented on pull request #157: URL: https://github.com/apache/lucene/pull/157#issuecomment-871334072
Simplified `AutomatonToTokenStream` and added license comment. I beasted the random tests a few hundred times and found 2 issues. 1)When completely separated edges get connected it can introduce gaps and cause book keeping errors. 2)The `checkGeneralization` test can miss paths where a hole in the unflattened graph would cross multiple nodes. The logic to navigate around issue 2 slows down `checkGeneralization` to the point I don't think it is useful so I commented that portion out. The test that calls it still checks if asserts are getting hit, and `testPathsNotLost` is checking if strings to make an automaton are accepted after the automaton is flattened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
