mikemccand commented on a change in pull request #191:
URL: https://github.com/apache/lucene/pull/191#discussion_r659860846
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##########
@@ -162,8 +162,14 @@ private void count(String field, List<MatchingDocs>
matchingDocs) throws IOExcep
if (limit > 0) {
totCount++;
}
+ Long previousValue = null;
Review comment:
+1, I think that can avoid the need for any boxing.
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##########
@@ -162,8 +162,14 @@ private void count(String field, List<MatchingDocs>
matchingDocs) throws IOExcep
if (limit > 0) {
totCount++;
}
+ Long previousValue = null;
Review comment:
+1, I think that can avoid the need for any boxing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
