gautamworah96 commented on a change in pull request #191:
URL: https://github.com/apache/lucene/pull/191#discussion_r660149249
##########
File path:
lucene/facet/src/test/org/apache/lucene/facet/TestLongValueFacetCounts.java
##########
@@ -382,19 +383,19 @@ public void testRandomMultiValued() throws Exception {
+ allSingleValued);
}
- long[][] values = new long[valueCount][];
- for (int i = 0; i < valueCount; i++) {
+ Long[][] values = new Long[docCount][];
Review comment:
Sure.
The next commit uses `long`s everywhere instead of `Long`s. In the test
class, it sorts values manually (because they are randomly generated) and then
uses the same logic of comparing with the previous value.
Just out of curiosity: why do we prefer a `long` over a `Long`? Saves us
boxing/unboxing time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
