jimczi commented on a change in pull request #185: URL: https://github.com/apache/lucene/pull/185#discussion_r657762626
########## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiNormsLeafSimScorer.java ########## @@ -62,6 +67,14 @@ weightList.add(field.weight); } } + + if (normsList.isEmpty() == false && normsList.size() != normFields.size()) { + throw new IllegalArgumentException( + getClass().getSimpleName() + + " requires norms to be consistent across fields: some fields cannot" + + " have norms enabled, while others have norms disabled"); Review comment: It's kind of an edge case but should we also throw the exception if scoring is not needed ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org