[ https://issues.apache.org/jira/browse/LUCENE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368445#comment-17368445 ]
ASF subversion and git services commented on LUCENE-9902: --------------------------------------------------------- Commit 2056d61c6f4546cd1086f6314c27aac1747d43a5 in lucene-solr's branch refs/heads/branch_8x from Gautam Worah [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2056d61 ] Backport LUCENE-9902 Minor fixes to the faceting API (#62) (#2516) Co-authored-by: Gautam Worah <gauwo...@amazon.com> > Update faceting API to use modern Java features > ----------------------------------------------- > > Key: LUCENE-9902 > URL: https://issues.apache.org/jira/browse/LUCENE-9902 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Reporter: Gautam Worah > Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > I was using the {{public int getOrdinal(String dim, String[] path)}} API for > a singleĀ {{path}} String and found myself creating an array with a single > element. We can start using variable length args for this method. > I also propose this change: > I wanted to know the specific count of an ordinal using using the > {{getValue}} API from {{IntTaxonomyFacets}} but the method is private. It > would be good if we could change it to {{protected}} so that users can know > the value of an ordinal without looking up the {{FacetLabel}} and then > checking its value. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org