[ 
https://issues.apache.org/jira/browse/LUCENE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366604#comment-17366604
 ] 

Mayya Sharipova commented on LUCENE-9902:
-----------------------------------------

[~gworah] It looks like this change has not been merged to branch_8_9 or 
branch_8x?  Should we adjust 
[lucene/CHANGES.txt|https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L390]
 file accordingly? 

> Update faceting API to use modern Java features
> -----------------------------------------------
>
>                 Key: LUCENE-9902
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9902
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Gautam Worah
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> I was using the {{public int getOrdinal(String dim, String[] path)}} API for 
> a single {{path}} String and found myself creating an array with a single 
> element. We can start using variable length args for this method.
> I also propose this change:
>  I wanted to know the specific count of an ordinal using using the 
> {{getValue}} API from {{IntTaxonomyFacets}} but the method is private. It 
> would be good if we could change it to {{protected}} so that users can know 
> the value of an ordinal without looking up the {{FacetLabel}} and then 
> checking its value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to