jtibshirani commented on a change in pull request #176:
URL: https://github.com/apache/lucene/pull/176#discussion_r647045642
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldVectorFormat.java
##########
@@ -114,14 +114,7 @@ public void close() throws IOException {
}
private VectorWriter getInstance(FieldInfo field) throws IOException {
- VectorFormat format = null;
Review comment:
I think the original logic was copied from `PerFieldDocValuesFormat`. My
understanding is that it only applied when writing to a segment with doc value
updates (and not when merging). `PerFieldPostingsFormat` never actually
consults the per field format when writing. I'd appreciate if someone could
double-check this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
