rmuir commented on pull request #134: URL: https://github.com/apache/lucene/pull/134#issuecomment-840134456
I added a small tweak to the test so that it always tests both the bulk and non-bulk cases. I just ran the test a few times before/after and inspected its test coverage each run like this: ```console $ ./gradlew -p lucene/core test --tests org.apache.lucene.codecs.lucene90.TestLucene90StoredFieldsFormat.testRandomStoredFieldsWithIndexSort coverage $ open ~/workspace/lucene/lucene/core/build/reports/jacoco/test/html/index.html ``` in order to also exercise the `MergeStrategy.VISITOR` case, simplest approach might be to use `addIndexes` at the end. Or just add a separate unit test for that case. I am looking into it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
