jpountz commented on a change in pull request #134:
URL: https://github.com/apache/lucene/pull/134#discussion_r630892171
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsWriter.java
##########
@@ -472,7 +479,7 @@ public void finish(FieldInfos fis, int numDocs) throws
IOException {
if (numBufferedDocs > 0) {
numDirtyChunks++; // incomplete: we had to force this flush
numDirtyDocs += numBufferedDocs;
Review comment:
Maybe we could move the accounting of `numDirtyChunks` and
`numDirtyDocs` to `flush` now to make things simpler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
