[GitHub] [lucene] neoremind commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

[GitBox]

neoremind commented on a change in pull request #91:
URL: https://github.com/apache/lucene/pull/91#discussion_r617409172



##########
File path: 
lucene/core/src/java/org/apache/lucene/util/bkd/MutablePointsReaderUtils.java
##########
@@ -39,13 +41,23 @@
   public static void sort(
       BKDConfig config, int maxDoc, MutablePointValues reader, int from, int 
to) {
     final int bitsPerDocId = PackedInts.bitsRequired(maxDoc - 1);

Review comment:
       Is this a little bit better?
   ```
   bool canUseStableSort = check....
   if (canUseStableSort) {
     StableMsbRadixSort.sort(..)
   } else {
     MsbRadixSort.sort(..)
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org