jpountz commented on pull request #91:
URL: https://github.com/apache/lucene/pull/91#issuecomment-823209788


   > I will give it a try, the first thing comes up my mind is to bring up a 
new prepare method,
   
   One idea I had in mind was to create a new class, something like 
`StableMSBRadixSorter` that would extend `MSBRadixSorter` to:
    - add the two `assign` and `finalizeAssign` methods that you currently 
added to `Sorter`,
    - override the way data gets rearranged to guarantee stability,
    - change the fallback sorter,
    - modify `radixSort(int,int,int,int)` to check whether data is already 
sorted before computing the common prefix length and the histogram of the 
leading bytes.
   
   > One more question, are there any places where doc id is not added 
increasingly?
   
   I don't remember how we deal with it, but we should check how this 
optimization plays with index sorting, since we would renumber doc IDs at flush 
time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to