rmuir commented on a change in pull request #80:
URL: https://github.com/apache/lucene/pull/80#discussion_r612614117
##########
File path: gradle/generation/snowball.gradle
##########
@@ -114,5 +133,5 @@ configure(project(":lucene:analysis:common")) {
}
}
- regenerate.dependsOn mustRunInOrder([snowball, "spotlessApply"])
+ regenerate.dependsOn wrapWithPersistentChecksums(snowball, [ andThenTasks:
"spotlessApply", ignoreWithSource: [downloadSnowballStemmers,
downloadSnowballWebsite, downloadSnowballData] ])
Review comment:
@dweiss I like that idea! There's always a good time to call them over
and over, if you are actually wrestling with grammar change or something.
Calling the whole "regenerate" even without the big DFA takes a couple minutes
for me (the ICU compilation is costly as an example). So its hard to remember
and properly exclude just the slow parts.
It's helpful to be able to just target regeneration of something specific
like `snowball` when doing some real concrete work with it. But it isn't useful
to iterate this way unless it also triggers reformatting and checksums, so that
tests and checks pass appropriately (if they should).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
