rmuir commented on a change in pull request #80:
URL: https://github.com/apache/lucene/pull/80#discussion_r611893685
##########
File path: gradle/generation/snowball.gradle
##########
@@ -114,5 +133,5 @@ configure(project(":lucene:analysis:common")) {
}
}
- regenerate.dependsOn mustRunInOrder([snowball, "spotlessApply"])
+ regenerate.dependsOn wrapWithPersistentChecksums(snowball, [ andThenTasks:
"spotlessApply", ignoreWithSource: [downloadSnowballStemmers,
downloadSnowballWebsite, downloadSnowballData] ])
Review comment:
from a user perspective this is a little frustrating. let's leave it for
now but please think about it, it is a bit frustrating that `gradlew snowball`
is essentially an incomplete, useless task now, becuase it doesnt run tidy nor
update checksums. Maybe these individual tasks simply shouldnt be exposed at
all, because they only cause pain, only `regenerate` really does everything
(such as updating the checksums files).
I tried out your branch and wanted to remove some now-obselete logic from
the shell script (hey, the less it does the better, would love to get rid of
it). So i ran `./gradlew snowball` with my modified shell script and it did
nothing: UP-TO-DATE everywhere.
ok, take two: i ran `./gradlew snowball --rerun-tasks` to test my changes,
but it didn't run tidy.
ok, take three: i ran `./gradlew snowball tidy --rerun-tasks`, which
accomplished what I wanted, unfortunately, precommit now fails because it
neglected to update any checksums :(
take four: i ran `./gradlew -p lucene/analysis/common regenerate
--rerun-tasks` to apply a more blunt instrument. But i forgot that damn 12GB
DFA is in there :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
