gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609667950



##########
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##########
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
       in.skipBytes(forUtil.numBytes(bitsPerValue) + (numExceptions << 1));
     }
   }
+
+  /**
+   * Fill {@code longs} with the final values for the case of all deltas being 
1. Note this assumes
+   * there are no exceptions to apply.
+   */
+  private static void prefixSumOfOnes(long[] longs, long base) {
+    System.arraycopy(IDENTITY_PLUS_ONE, 0, longs, 0, ForUtil.BLOCK_SIZE);
+    // This loop gets auto-vectorized
+    for (int i = 0; i < ForUtil.BLOCK_SIZE; ++i) {
+      longs[i] += base;
+    }
+  }
+
+  /**
+   * Fill {@code longs} with the final values for the case of all deltas being 
{@code val}. Note
+   * this assumes there are no exceptions to apply.
+   */
+  private static void prefixSumOf(long[] longs, long base, long val) {
+    for (int i = 0; i < ForUtil.BLOCK_SIZE; i++) {
+      longs[i] = (i + 1) * val + base;

Review comment:
       @rmuir instance type swap did the trick. Thanks so much! Grabbing your 
command from above, here's the suspicious difference (in case this helps in the 
future):
   * instance type: m4.10xlarge
   ```
   m4.10xl% sudo journalctl -k | grep PMU                                       
                                                                                
                                             
   Mar 24 15:02:23 localhost kernel: Performance Events: unsupported p6 CPU 
model 63 no PMU driver, software events only.
   Mar 24 15:02:23 localhost kernel: RAPL PMU: API unit is 2^-32 Joules, 0 
fixed counters, 655360 ms ovfl timer
   ```
   * instance type: m5.12xlarge
   ```
   m5.12xl% sudo journalctl -k | grep PMU                                       
                                                                         
   Apr 08 04:02:43 localhost kernel: Performance Events: Skylake events, Intel 
PMU driver.
   Apr 08 04:02:43 localhost kernel: RAPL PMU: API unit is 2^-32 Joules, 0 
fixed counters, 10737418240 ms ovfl timer
   ```
   I've confirmed `perfasm` is working for me. I'll get some results updated 
here shortly. Thanks again!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to