jpountz commented on a change in pull request #64:
URL: https://github.com/apache/lucene/pull/64#discussion_r608399324
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java
##########
@@ -373,6 +373,7 @@ private SerializedDocument(DataInput in, int length, int
numStoredFields) {
private int[] offsets = IntsRef.EMPTY_INTS;
private int[] numStoredFields = IntsRef.EMPTY_INTS;
+ private StoredFieldsInts intsReader = new StoredFieldsInts();
Review comment:
let's make it final?
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/StoredFieldsInts.java
##########
@@ -73,17 +136,59 @@ static void readInts(IndexInput in, int count, int[]
values, int offset) throws
}
}
- private static void readInts8(IndexInput in, int count, int[] values, int
offset)
- throws IOException {
- for (int i = 0; i < count; i++) {
- values[offset + i] = Byte.toUnsignedInt(in.readByte());
+ private void readInts8(IndexInput in, int count, int[] values, int offset)
throws IOException {
Review comment:
Unfortunately, for the JVM to auto-vectorize this, I think we'd need
`values` to be a `long[]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
