mayya-sharipova commented on a change in pull request #11:
URL: https://github.com/apache/lucene/pull/11#discussion_r598288749
##########
File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
##########
@@ -972,6 +671,64 @@ private boolean assertNotFinished() {
return true;
}
+ private FieldInfo addField(
+ String name,
+ int preferredFieldNumber,
+ boolean storeTermVector,
+ boolean omitNorms,
+ boolean storePayloads,
+ IndexOptions indexOptions,
+ DocValuesType docValues,
+ long dvGen,
+ Map<String, String> attributes,
+ int dataDimensionCount,
+ int indexDimensionCount,
+ int dimensionNumBytes,
+ int vectorDimension,
+ VectorValues.SearchStrategy vectorSearchStrategy,
+ boolean isSoftDeletesField) {
+ // This field wasn't yet added to this in-RAM
+ // segment's FieldInfo, so now we get a global
+ // number for this field. If the field was seen
+ // before then we'll get the same name and number,
+ // else we'll allocate a new one:
+ assert assertNotFinished();
+ final int fieldNumber =
+ globalFieldNumbers.addOrGet(
Review comment:
Addressed in 6dc9f27 and 55fa8c8
##########
File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
##########
@@ -339,110 +350,17 @@ synchronized int addOrGet(
String fieldName,
int preferredFieldNumber,
IndexOptions indexOptions,
+ boolean storeTermVector,
Review comment:
Addressed in 6dc9f27 and 55fa8c8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
