zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r598055282
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -87,6 +89,8 @@
* True if drilling down by a whole dimension, to match all documents that
had any value for
* this dimension, is necessary (default is true)
*/
+ // nocommit should this (control for only label / dim name indexing) be
deprecated to favor the
Review comment:
I've pushed a new commit using enum with above definition for now, and
moving the flag from `FacetsConfig` to `DimConfig` so that it's still
configurable at the field level. Please let me know if any changes need to be
made there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]