zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r598035273



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -178,6 +190,25 @@ public synchronized void 
setRequireDimensionDrillDown(String dimName, boolean v)
     ft.requireDimensionDrillDown = v;
   }
 
+  /**
+   * Specify whether drill down functionality as a whole should be disabled. 
Default to false for
+   * backward compatibility.

Review comment:
       Thank Greg for the comment! I was coding at night after some beer so 
might have used the words a bit casually :D , but yes my original meaning there 
was that the default setting should not break existing Lucene clients upgrading 
from older version. I'll re-word this java doc entirely as I'll change the API 
to taking enum instead of boolean. 
   
   For `enableDrillDown` vs. `disableDrillDown`, please see my reply to 
Robert's comment above.

##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -372,7 +403,10 @@ private void processFacetFields(
 
         // Drill down:

Review comment:
       I think this logic may or may not be correct actually, as it depends on 
whether full path terms is considered as "drill down terms" (see my question to 
Mike above).
   
   Also, the index `i` in `pathToString(cp.components, i)` above is used as 
"length". So with the original implementation when `start = cp.length`,  
`pathToString(cp.components, start)`  will still be executed and give the full 
path including every element inside `cp.components`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to