HoustonPutman commented on a change in pull request #231:
URL:
https://github.com/apache/lucene-solr-operator/pull/231#discussion_r589558078
##########
File path: helm/solr-operator/Chart.yaml
##########
@@ -95,4 +95,10 @@ annotations:
name: "example"
numThreads: 4
image:
- tag: 8.7.0
\ No newline at end of file
+ tag: 8.7.0
+
+dependencies:
+ - name: 'zookeeper-operator'
+ version: 0.2.9
+ repository: https://charts.pravega.io
+ condition: useZkOperator
Review comment:
[The helm
docs](https://helm.sh/docs/chart_best_practices/dependencies/#conditions-and-tags)
give some good guidance. I think this logic is very good in general. We should
just use the name `zookeeper-operator` instead of `zookeeperOperator`, since
that's the name of the dependency.
We should also think about maybe including backwards compatibility of the
old `useZookeeperOperator` option, which was unfortunately a string `"true"`.
I can take a stab at updating the documentation around this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
