[ 
https://issues.apache.org/jira/browse/LUCENE-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287995#comment-17287995
 ] 

Michael McCandless commented on LUCENE-9795:
--------------------------------------------

+1 for that simple patch to fix {{CheckIndex}}!  I double checked and confirmed 
that {{checkSortedDocValues}} itself is already (more efficiently) stepping 
through all ordinals, confirming it can retrieve the {{BytesRef}} for each.

> investigate large checkindex/grouping regression in nightly benchmarks
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-9795
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9795
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>            Priority: Major
>         Attachments: LUCENE-9795.patch, 
> Screen_Shot_2021-02-21_at_09.17.53.png, Screen_Shot_2021-02-21_at_09.30.30.png
>
>
> In the nightly benchmark, checkindex times increased more than 4x on the 2/16 
> datapoint
> Looking at the commits on 2/15, most obvious thing to look into is docvalues 
> terms dict compression: LUCENE-9663
> Will try to pinpoint it more, my concern is some perf bug such as every 
> single term causing decompression of the whole block repeatedly (missing 
> seek-within-block opto?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to