thelabdude commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r579370235
##########
File path: controllers/solrprometheusexporter_controller.go
##########
@@ -209,7 +209,22 @@ func (r *SolrPrometheusExporterReconciler) Reconcile(req
ctrl.Request) (ctrl.Res
}
}
- deploy :=
util.GenerateSolrPrometheusExporterDeployment(prometheusExporter,
solrConnectionInfo, configXmlMd5, tlsClientOptions)
+ basicAuthMd5 := ""
+ if prometheusExporter.Spec.SolrReference.BasicAuthSecret != nil {
+ selector :=
prometheusExporter.Spec.SolrReference.BasicAuthSecret
+ basicAuthSecret := &corev1.Secret{}
+ err := r.Get(context.TODO(), types.NamespacedName{Name:
selector.Name, Namespace: prometheusExporter.Namespace}, basicAuthSecret)
+ if err != nil {
+ return reconcile.Result{}, err
+ }
+ passBytes, ok := basicAuthSecret.Data[selector.Key]
Review comment:
afaik, `stringData` is a convenience for YAML and secrets always store
all data in `data` but I'll verify if they supply via `stringData` that we can
read it from `data`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
