HoustonPutman commented on pull request #221: URL: https://github.com/apache/lucene-solr-operator/pull/221#issuecomment-781467939
A few thoughts: - I completely agree that only files used in the filesystem in Solr (solr.xml, log4j, prometheus exporter config) should be stored in configMaps. Those that are merely meant to bootstrap Zookeeper, should not be stored in configMaps. - I like the initAnonymousEndpoints, but just so that I'm clear, that's just for the bootstrapped security.json right? Even if the user changes that list after the cluster is created, it won't be reflected in the security.json? If so maybe we leave it up to the users to use the security APIs to manage that. Not really sure yet either way. - For the HTTP Probes, would it not be easy to merely remove the auth from those initially? Or I guess we can't tell whether the user has removed auth for it or not, so we need to provide it by default. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
