[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2405: LUCENE-9790: Hunspell: avoid slow dictionary lookup if the word's hash isn't there

[GitBox]

donnerpeter commented on a change in pull request #2405:
URL: https://github.com/apache/lucene-solr/pull/2405#discussion_r579171729



##########
File path: 
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -160,7 +160,8 @@ public void testDictionariesLoadSuccessfully() throws 
Exception {
           try {
             Dictionary dic = loadDictionary(aff);
             totalMemory.addAndGet(RamUsageTester.sizeOf(dic));
-            totalWords.addAndGet(RamUsageTester.sizeOf(dic.words));
+            totalWords.addAndGet(
+                RamUsageTester.sizeOf(dic.words) + 
RamUsageTester.sizeOf(dic.wordHashes));

Review comment:
       About ~7% memory usage increase on average, at most 512KB




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org