epugh opened a new pull request #2402: URL: https://github.com/apache/lucene-solr/pull/2402
Not sure on rule, snitch, and policy on if they are still real. Wish we had docs for rule, snitch, and policy in the Solr Ref Guide page under CREATE, appears to be half fixed. # Description Adding some parameters to make V2 match V1. # Solution I tested the addition of `readOnly` and it worked great. I didn't test `rule`, `snitch` or `policy` because I don't understand if they are still real or not, and it was unclear to me from reading the Ref Guide if they existed. Some cleanup needed there! # Tests Manually tested `readOnly` being passed in. # Checklist Please review the following and check all that apply: - [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ X] I have created a Jira issue and added the issue ID to my pull request title. - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X ] I have developed this patch against the `master` branch. - [X ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ X] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
