[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283655#comment-17283655
]
Jason Gerlowski commented on SOLR-14920:
----------------------------------------
bq. Maybe we could start with just the contribs & docker, leaving aside Solr
Core & SolrJ?
+1 That's all I was trying to point out above. There's plenty of
ref-impl-agnostic code that could be cleaned up today, no matter how much
deference you want to give to ref_impl.
Personally I don't see any reason to discourage contributors from running on
ref_impl affected packages either if they're willing to do it on both branches
(master + ref_impl), and if doing so will avoid the majority of conflicts as
Jan and Dawid suggested. But I'm happy to drop that point if there's consensus
on the middle-ground point above.
bq. We've lived with the formatting anomalies for many years, I don't see the
driver for pushing this forward before the reference impl is resolved
With this tool integrated into lucene-solr, any time spent on formatting code
is 100% wasted effort. It's not a sexy end-user feature or anything, but
recovering the time we're all wasting daily seems like a big-enough carrot to
merit the work now. (Especially when there's no concrete timeline for
ref_impl, afaik?)
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
