[
https://issues.apache.org/jira/browse/SOLR-15145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281362#comment-17281362
]
Timothy Potter commented on SOLR-15145:
---------------------------------------
After some digging around in the code again, there's really no way we can
remove `base_url` from the stored state in ZK for 8.8 w/o breaking back-compat
for SolrJ if clients are using {{ZkClientClusterStateProvider}} to load cluster
state directly from ZK. I should have caught this when implementing SOLR-12182
:( Obviously we can't make any changes to existing pre 8.8.0 SolrJ clients ...
Perhaps we could introduce a System property in 8.8.1 that re-enables storing
the `base_url` in ZK for these back-compat use cases? That will at least give
people an out when they can't upgrade their SolrJ version. Given the rolling
restart problem, I'm inclined to make this System property default to storing
the `base_url` instead of having to explicitly turn this behavior on, but want
to think about this a bit...
> Older versions of SolrJ (pre-8.8.0) hit an NPE when computing the base_url
> for core node props
> ----------------------------------------------------------------------------------------------
>
> Key: SOLR-15145
> URL: https://issues.apache.org/jira/browse/SOLR-15145
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 8.8
> Reporter: Timothy Potter
> Assignee: Timothy Potter
> Priority: Critical
> Fix For: 8.8.1
>
>
> From the mailing list:
> {code}
> Caused by: java.lang.NullPointerException
> at
> deployment.uleaf.ear//org.apache.solr.common.cloud.ZkCoreNodeProps.getCoreUrl(ZkCoreNodeProps.java:53)
> at
> deployment.uleaf.ear//org.apache.solr.client.solrj.impl.BaseCloudSolrClient.lambda$sendRequest$2(BaseCloudSolrClient.java:1161)
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1540)
> at
> deployment.uleaf.ear//org.apache.solr.client.solrj.impl.BaseCloudSolrClient.sendRequest(BaseCloudSolrClient.java:1159)
> at
> deployment.uleaf.ear//org.apache.solr.client.solrj.impl.BaseCloudSolrClient.requestWithRetryOnStaleState(BaseCloudSolrClient.java:934)
> ... 166 more
> {code}
> see:
> https://lists.apache.org/thread.html/r3d131030f0a7026235451f71fabdae6d6b7c2f955822c75dcad4d41f%40%3Csolr-user.lucene.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
