mayya-sharipova commented on a change in pull request #2256:
URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r570458862
##########
File path:
lucene/core/src/java/org/apache/lucene/index/StandardDirectoryReader.java
##########
@@ -143,12 +158,17 @@ static StandardDirectoryReader open(
writer.incRefDeleter(segmentInfos);
+ if (writer.getConfig().getLeafSorter() != null) {
+ readers.sort(writer.getConfig().getLeafSorter());
Review comment:
@mikemccand Thank you for your feedback.
The intent was to keep `leafSorter` constant and non-updatable, as
`indexWriter.getConfig` returns `LiveIndexWriterConfig` that doesn't allow
setting of a new `leafSorter`. I understand that `leafSorter` in config can
still be changed, and your comment is very valid.
But In 8155f2e2abd4ed3a6280aae940d018dfe3b3dad1 I've moved sorting of
leaves to the constructor, so hopefully this should resolve this concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
