[
https://issues.apache.org/jira/browse/LUCENE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275776#comment-17275776
]
Robert Muir commented on LUCENE-9711:
-------------------------------------
I did try checkboxing the eclipse javadocs linter's "report non visible
references" just for kicks, but that seems to be about something else. Its
another avenue to explore, maybe ecj has some check that would trip here.
> "gradle precommit" no longer catches accidental package-private APIs?
> ---------------------------------------------------------------------
>
> Key: LUCENE-9711
> URL: https://issues.apache.org/jira/browse/LUCENE-9711
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: master (9.0)
> Reporter: Michael McCandless
> Priority: Major
> Attachments: look_ma_no_link.png
>
>
> While backporting the new exciting deterministic multi-segment indexing tool,
> LUCENE-9694, {{ant precommit}} failed, because the new {{DocumentSelector}}
> API was accidentally package private, missing its {{public}} modifier.
> [Aside: I sometimes feel we should not put unit tests in the same package as
> the APIs they are testing. We of course do this to make testing internal,
> package-private state, possible/easier. But it then leads to API bugs like
> this, where we fail to make an API public when it should be.]
> Anyways, luckily, the old crazy hacky Python javadoc linter in 8.x caught
> this issue, and I fixed it on backport, and will shortly fix it in mainline
> as well. But {{gradle precommit}} on mainline failed to catch it, I think?
> Is this a known regression in our {{gradle}} migration? Do we have plans to
> somehow recover it? It clearly sometimes catches important API bugs! And
> this is not the first time it's caught such bugs...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
