[GitHub] [lucene-solr] jaisonbi commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

[GitBox]

jaisonbi commented on pull request #2213:
URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-768786435


   I also want to use different configurations, so we can enable terms dict 
compression only.  I plan to remove the enum Mode from Lucene80DocValuesFormat, 
and add a new config class as below:
   
   ```
   public enum CompressionMode {
       NONE,
       LZ4
     }
   
     public static class DocValuesConfig {
       // Compression mode for terms dict from SortedSet/Sorted DocValues.
       private CompressionMode termsDictCompressionMode;
       // Compression mode for binary DocValues.
       private CompressionMode binaryDocValueCompressionMode;
   
       public DocValuesConfig() {
         this(CompressionMode.NONE, CompressionMode.NONE);
       }
   
       public DocValuesConfig(CompressionMode termsDictCompressionMode, 
CompressionMode binaryDocValueCompressionMode) {
         this.termsDictCompressionMode = termsDictCompressionMode;
         this.binaryDocValueCompressionMode = binaryDocValueCompressionMode;
       }
   
       public CompressionMode getBinaryDocValueCompressionMode() {
         return binaryDocValueCompressionMode;
       }
   
       public boolean isTermsDictCompressionEnabled() {
         return CompressionMode.LZ4 == this.termsDictCompressionMode;
       }
   
       public boolean isBinaryDocValueCompressionEnabled() {
         return CompressionMode.LZ4 == this.binaryDocValueCompressionMode;
       }
     }
   ```
   Before I commit the new changes, please share your thoughts on this.  
@bruno-roustant  @zhaih 
   Thanks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org