[
https://issues.apache.org/jira/browse/SOLR-13608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269375#comment-17269375
]
Jason Gerlowski commented on SOLR-13608:
----------------------------------------
As written, SIP-12 proposes that support for creating non-incremental backups
be removed at the same time as incremental-backup support is added i.e. there
is no overlap where creating both formats are supported. (Restoring the old
format would still be supported through the next major release line.)
In spirit this is still what I'd like to do, but there's a testing issue with
this approach - if you want to test out restoring a nonincremental backup, you
need to be able to _create_ one first. We could get around this by building a
nonincremental backup offline and committing it to the repo, but this would be
pretty hacky. I could also restructure the nonincremental backup code into a
utility that only test code can access. But this would involve a lot of
refactoring and would lose some fidelity in terms of testing (i.e. the code
creating nonincremental backups in our tests wouldn't be the same code that
created those backups for users).
So instead of removing support entirely for nonincremental backup creation, I'm
leaning towards leaving it in until Solr drops support for restoring the old
format entirely. The incremental backup would be the default and the only one
advertised in the ref-guide, but tests (and persistent users) could create
snapshot-style backups by providing an undocumented flag parameter to the
backup API.
> Incremental backup for Solr
> ---------------------------
>
> Key: SOLR-13608
> URL: https://issues.apache.org/jira/browse/SOLR-13608
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Cao Manh Dat
> Assignee: Jason Gerlowski
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> SIP-12 lays out a plan for adding support for incremental backups to Solr.
> At a high level, the idea is that Solr will be able to store multiple backups
> in the same location, and backups beyond the first one will only upload those
> files that were not uploaded by previous backups.
> This involves changes to the file structure within a particular backup
> location. It also entails changes to some of the backup/restore API
> parameters and semantics, to accommodate storing multiple backups in the same
> place, etc.
> This ticket covers the changes required for this functionality, as described
> in SIP-12 unless mentioned specifically below. It does not implement all of
> [SIP-12.|https://cwiki.apache.org/confluence/display/SOLR/SIP-12%3A+Incremental+Backup+and+Restore]
> Same-collection-restoration, support for popular proprietary blob stores,
> etc. are left for separate tickets in an attempt to keep PRs manageable and
> conceptually cohesive.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
