dsmiley commented on a change in pull request #2215:
URL: https://github.com/apache/lucene-solr/pull/2215#discussion_r559731569
##########
File path: solr/CHANGES.txt
##########
@@ -186,6 +186,9 @@ Other Changes
* SOLR-14034: Remove deprecated min_rf references (Tim Dillon)
+* SOLR-14067: StatelessScriptUpdateProcessor moved to it's own
/contrib/scripting/ package instead
+ of shipping as part of Solr due to security concerns. Renamed to
ScriptingUpdateProcessor. (Eric Pugh)
Review comment:
I agree 100% on seeing \*Factory all over the config being poor for the
reason you gave. It could also be argued that even the "UpdateProcessor" part
is quite redundant based on where we declare it. Have you noticed changes in
Lucene to how schema analysis components are resolved, affecting the Solr
schema (master only)? See
solr/server/solr/configsets/_default/conf/managed-schema -- `<filter
name="lowercase"/>` it's beautiful. No "FilterFactory" suffix. Eventually I
hope we can take the same approach throughout Solr. Lucene uses an SPI
approach which means a special file listing each implementation. Something
like that could be embraced. No need to separate the factory from inner class
over this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
