[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255166#comment-17255166
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14723:
------------------------------------------------------
Thanks for working on this [~trdillon].
bq. I am now investigating a failing
org.apache.solr.search.join.CrossCollectionJoinQueryTest and the error log is
making me think it might be caused by
org.apache.solr.core.SolrConfig.PluginOpts.REQUIRE_CLASS but I'm not sure.
I believe you are right. It seems like (Looking at the
{{CacheConfig.getConfig}} method) could be optional, but we are requiring it
for custom caches (not for the main caches though). I think you are right, and
we should remove the
{{org.apache.solr.core.SolrConfig.PluginOpts.REQUIRE_CLASS}} to the
{{SolrCache}} plugin, since we anyway have a default for that attribute.
bq. Also there was a failure in org.apache.solr.search.TestLFUCache, which
along with org.apache.solr.search.TestLRUCache and
org.apache.solr.search.TestFastLRUCache have not yet been deprecated it seems.
You mean the tests aren't deprecated? What's the error?
bq. Tomas Eduardo Fernandez Lobbe Erick Erickson should I open a PR with what
I've done already and try to sort these other issues out within that?
Yes. please do.
> Rremove the class atribute for the caches in the _default/example configsets
> ----------------------------------------------------------------------------
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomas Eduardo Fernandez Lobbe
> Priority: Trivial
> Labels: newdev
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> <filterCache class="solr.FastLRUCache"
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
