[ 
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254937#comment-17254937
 ] 

Tim Dillon commented on SOLR-14723:
-----------------------------------

Thanks [~shshnk28]. I've removed the references to the class attribute in the 
config sets I could find them in, 32 in total.

I also found the cause of the failed 
_org.apache.solr.search.json.TestJsonRequest_ and seemed to have resolved that.

I am now investigating a failing 
_org.apache.solr.search.join.CrossCollectionJoinQueryTest_ and [the error 
log|https://pastebin.com/CCrfts5G] is making me think it might be caused by 
_org.apache.solr.core.SolrConfig.PluginOpts.REQUIRE_CLASS_ but I'm not sure.

Also there was a failure in _org.apache.solr.search.TestLFUCache_, which along 
with _org.apache.solr.search.TestLRUCache_ and 
_org.apache.solr.search.TestFastLRUCache_ have not yet been deprecated it seems.

[~tflobbe] [~erickerickson] should I open a PR with what I've done already and 
try to sort these other issues out within that?

 

> Rremove the class atribute for the caches in the _default/example configsets
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-14723
>                 URL: https://issues.apache.org/jira/browse/SOLR-14723
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Tomas Eduardo Fernandez Lobbe
>            Priority: Trivial
>              Labels: newdev
>
> In 8.x branch, the default and example configsets include LRUCache and 
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> <filterCache class="solr.FastLRUCache"
>                  size="512"
>                  initialSize="512"
>                  autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute 
> completely and let the default take over (as it's in master), this should 
> make upgrading configsets easier:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to