vonbox commented on pull request #2118:
URL: https://github.com/apache/lucene-solr/pull/2118#issuecomment-745963448


   > Thanks for adding the test! it passes for me when run alone, but not as 
part of the full class, can you verify in your environment as well?
   > 
   > `./gradlew :solr:core:test --tests TestFunctionQuery`
   
   That's strange, sometimes it succeeds, but often it fails. It looks like 
documents from previous tests pop up in the result, which makes me wonder what 
the clearIndex call actually does? I took the easy way out by removing the 
numFound check. So now it is just making sure no exception is thrown when 
executing the function, which is a good enough test I think.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to