madrob commented on pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118#issuecomment-741045328
Overall the fix is definitely good, and I think it's correct, just a few minor questions about it for completeness. Thank you for opening the PR! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
