TomMD commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r539505535
########## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/RandomPlacementFactory.java ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cluster.placement.plugins; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashSet; +import java.util.Random; +import java.util.Set; + +import com.google.common.annotations.VisibleForTesting; +import org.apache.solr.cluster.Cluster; +import org.apache.solr.cluster.Node; +import org.apache.solr.cluster.Replica; +import org.apache.solr.cluster.SolrCollection; +import org.apache.solr.cluster.placement.*; + +/** + * <p>Factory for creating {@link RandomPlacementPlugin}, a placement plugin implementing random placement for new + * collection creation while preventing two replicas of same shard from being placed on same node..</p> + * + * <p>See {@link AffinityPlacementFactory} for a more realistic example and documentation.</p> + */ +public class RandomPlacementFactory implements PlacementPluginFactory { + + @Override + public PlacementPlugin createPluginInstance() { + return new RandomPlacementPlugin(); + } + + public static class RandomPlacementPlugin implements PlacementPlugin { + private Random random = new Random(); Review comment: @murblanc Sorry for the delay, this was missed. The above issue is produced by FSB which suggests `@suppressFBWarnings`. See [here](http://findbugs.sourceforge.net/api/edu/umd/cs/findbugs/annotations/SuppressFBWarnings.html) for the method to suppress in a case by case basis. If you'd like to remove the warning globally then you can add `ignore = [ "PREDICTABLE_RANDOM" ]` to the `.muse/config.toml` file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
